-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make actions compatible with newer Sylius versions #199
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.11.x #199 +/- ##
============================================
- Coverage 10.17% 10.06% -0.12%
- Complexity 353 358 +5
============================================
Files 62 62
Lines 1091 1103 +12
============================================
Hits 111 111
- Misses 980 992 +12
Continue to review full report at Codecov.
|
composer.json
Outdated
@@ -32,6 +31,7 @@ | |||
}, | |||
"require-dev": { | |||
"doctrine/doctrine-bundle": "^1.2.13", | |||
"friendsofsymfony/rest-bundle": "^2.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add ^2.8 || ^3.0
and then add it to require
instead?
) { | ||
private ?Environment $twig; | ||
|
||
public function __construct(?ViewHandlerInterface $viewHandler, FormFactoryInterface $formFactory, Environment $twig = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the arguments on 3 lines
Fixes #197