Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Origin property to the GiftCard #171

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Add Origin property to the GiftCard #171

merged 4 commits into from
Nov 3, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Nov 3, 2021

Also define this property automatically according to where it has been created.

Fix #166

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #171 (67e44f7) into 0.12.x (bc85b3f) will increase coverage by 0.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             0.12.x     #171      +/-   ##
============================================
+ Coverage     37.72%   38.57%   +0.84%     
- Complexity      447      454       +7     
============================================
  Files            87       88       +1     
  Lines          1450     1470      +20     
============================================
+ Hits            547      567      +20     
  Misses          903      903              
Impacted Files Coverage Δ
...tionExtension/GiftCardsByLoggedInUserExtension.php 100.00% <ø> (ø)
src/Api/DataPersister/GiftCardDataPersister.php 100.00% <100.00%> (ø)
src/Factory/GiftCardFactory.php 100.00% <100.00%> (ø)
src/Model/GiftCard.php 71.57% <100.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc85b3f...67e44f7. Read the comment docs.

@Roshyo Roshyo requested a review from loevgaard November 3, 2021 08:02
Copy link
Member

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veeery nice PR 🎉

@Roshyo Roshyo merged commit 3f99ace into 0.12.x Nov 3, 2021
@Roshyo Roshyo deleted the add-origin-property branch November 3, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants