Add normalization to incoming Unicode data #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All unicode input now gets 'NFD' normalization, which ensures that all characters that look the same are represented by the same code points. 'NFD' was chosen because it is the expanded for which will cause (for example) 'é' to be placed immediately after 'e' rather than after 'z'. Users can choose 'NFKD' with ns.COMPATIBILITYNORMALIZE (or ns.CN) which will change certain characters to their compatible (and often ASCII) representation. This may be useful to cause force numbers in odd representations to be transformed to ASCII which will potentially give better sorting orders. This will close issue #44.
|
This will address #44 |
The input normalization has been moved out of the "input_transform" function (which was called in the "parse_string" function) and now is the first step of the "parse_string" function. This is because the data needs to be normalized even if the "input_transform" function is skipped. Tests have been reworked to understand this change.
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 99.61% 99.62% +<.01%
==========================================
Files 10 10
Lines 522 535 +13
==========================================
+ Hits 520 533 +13
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize astonishment, Unicode data is now normalized to the 'NFD'
normalization form to make the sorting sane. Documentation has been updated
to discuss this where appropriate.
The user has the option of choosing 'NFKD'.