Add ability to sort like the file browser for each operating system #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic tests
This will work on any operating system. The current implementation is known to not work on non-Windows. Future commits will fix this.
ICU is used to sort on UNIX-based platforms. If not given, the results are OK, but not exactly what you would expect.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 99.53% 99.56% +0.02%
==========================================
Files 10 10
Lines 431 460 +29
==========================================
+ Hits 429 458 +29
Misses 2 2
Continue to review full report at Codecov.
|
SethMMorton
force-pushed
the
windows-exporer-sorting
branch
from
cc86d66
to
18c76a7
Compare
earonesty
reviewed
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
os_sorted,os_sort_keygen, andos_sort_key. These functions attempt to sort its input the same as the file browser on the user's operating system.Sadly, for UNIX systems you need PyICU otherwise the result is not great.
This closes #41.