Improve column alignment in test logs. #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi tests would previously create a NewPrettyPrinter per log entry to disable dimming and dynamic column widening since that caused problems when multiple processes, each with their own pretty printer, were sharing the same output. These days all processes in multi tests forward their log entries to the main process which has a single logger. Therefore we can reuse the same pretty printer, which gives us proper dimming and column widening.
spetrovic77
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously create a NewPrettyPrinter per log entry to disable dimming, which had the unfortunate side-effect of not aligining component and file:line columns. We now reuse a NewPrettyPrinter, but explicitly disable dimming inside it and start it off with wide columns,