Validate listener names at application startup. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
approved these changes
Aug 10, 2023
| @@ -101,7 +100,7 @@ func fillListeners(impl any, get func(name string) (net.Listener, string, error) | |||
|
|
|||
| // The listener's name is the field name, unless a tag is present. | |||
| name := t.Name | |||
| if tag := t.Tag.Get("weaver"); tag != "" { | |||
| if tag, ok := t.Tag.Lookup("weaver"); ok { | |||
There was a problem hiding this comment.
This was intentional: I was writing an empty service and wanted to use the empty listener name. 🤣
Thanks for fixing!
I don't think we do. Let me work on that in another PR. |
This PR extends the `validateRegistrations` function to also validate listener names when a Service Weaver application begins. As with PR #500, this PR aims to catch permanent and easily avoidable programming errors immediately. I also fixed a small bug in listener name validation. Previously, if a listener had a `weaver:""` annotation, it was being ignored. Now, it is being rejected (since `""` is not a valid listener name). I also updated the website documentation to describe legal listener names.
mwhittaker
force-pushed
the
validate_listener_names
branch
from
5ae0192 to
522830c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
validateRegistrationsfunction to also validate listener names when a Service Weaver application begins. As with PR #500, this PR aims to catch permanent and easily avoidable programming errors immediately.I also fixed a small bug in listener name validation. Previously, if a listener had a
weaver:""annotation, it was being ignored. Now, it is being rejected (since""is not a valid listener name).I also updated the website documentation to describe legal listener names.