Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Perfetto UI from JavaScript. #478

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Display Perfetto UI from JavaScript. #478

merged 2 commits into from
Jul 24, 2023

Conversation

spetrovic77
Copy link
Contributor

@spetrovic77 spetrovic77 commented Jul 20, 2023

This fixes the issue where the Perfetto server has to run on port 9001 and serve traces on the "/" path.

Now, the dashboard serves traces on its local server. This simplifies trace serving and allows multiple
dashboard commands to serve traces independently.

Other changes:

  • Moved the perfetto code into a separate runtime package.
cast2.webm

This fixes the issue where the Perfetto server has to run
on port 9001 and serve traces on the "/" path.

Now, the dashboard serves traces on its local server.
@spetrovic77 spetrovic77 self-assigned this Jul 20, 2023
Copy link
Collaborator

@ghemawat ghemawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplifications!

internal/status/templates/traces.html Show resolved Hide resolved
internal/status/templates/traces.html Show resolved Hide resolved
@spetrovic77 spetrovic77 merged commit 0be465f into main Jul 24, 2023
7 checks passed
@spetrovic77 spetrovic77 deleted the trace2 branch July 24, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants