Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a euro to USD parser #276

Open
chelming opened this issue Oct 17, 2023 · 10 comments
Open

create a euro to USD parser #276

chelming opened this issue Oct 17, 2023 · 10 comments
Labels
help wanted Extra attention is needed new parser Ideas for new parsers

Comments

@chelming
Copy link
Collaborator

https://exchangeratesapi.io/

should it happen automatically like the C to F parser? 🤷‍♀️

@Narasimha677
Copy link

if we integrate that api we have only 250 limit per month right?

@wiz0floyd
Copy link
Collaborator

Yes, though I would be shocked if we run into that limit.

I don't think it should happen every time. I suggest trigger with a 💶 or 💵 reaction.

@wiz0floyd
Copy link
Collaborator

@earlduque
Copy link
Collaborator

just make sure to have a failure path so the bot can explain why it didn't run

@eriemer1
Copy link
Contributor

eriemer1 commented Oct 2, 2024

Why not just leverage the oob currency conversion?
if you add a record to fx_currency_instance with the amount and currency and set the reference currency to the one you want to convert to it will automatically fill in the reference amount with the converted value.

There are only 5 currencies active oob, but we could turn on the full list and the exchange rates update nightly.

@wiz0floyd
Copy link
Collaborator

wiz0floyd commented Oct 2, 2024 via email

@Narasimha677
Copy link

Yes, though I would be shocked if we run into that limit.

I don't think it should happen every time. I suggest trigger with a 💶 or 💵 reaction.

did you mean if we ran out free service then we just show the currency emoji?

@wiz0floyd
Copy link
Collaborator

wiz0floyd commented Oct 2, 2024 via email

@eriemer1
Copy link
Contributor

eriemer1 commented Oct 2, 2024

That’s a good point. And with the right api we could include crypto

Maybe Chris is using Slacker for forex trades and needs real time data.

@chelming
Copy link
Collaborator Author

related to #293

@chelming chelming added new parser Ideas for new parsers help wanted Extra attention is needed labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new parser Ideas for new parsers
Projects
None yet
Development

No branches or pull requests

5 participants