Allow specifying browser binary path

[sohang3112]

Fixes Issue 645.

Add a binary_path option to all DriverManager classes to manually specify location of browser. This is useful when the browser is installed in a non-standard location.

Example test script using Chrome:

from selenium import webdriver
from selenium.webdriver.chrome.service import Service as ChromeService
from selenium.webdriver.chrome.options import Options as ChromeOptions
from webdriver_manager.chrome import ChromeDriverManager

chrome_path = "/custom/path/to/chrome"

manager = ChromeDriverManager(browser_path=chrome_path)
chromedriver_path = manager.install()

options = ChromeOptions()
options.binary_location = chrome_path
driver = webdriver.Chrome(service=ChromeService(chromedriver_path), options=options)

[sohang3112]

@SergeyPirogov please review my PR. Let me know if any changes are required from my side.

[sohang3112]

@SergeyPirogov did you have a chance to review my PR yet?

[sohang3112]

@aleksandr-kotlyar Can you please review this PR?

[MarcelWilson]

@sohang3112 good luck. I have had a PR open since Oct 9 with no feedback. 😞

[sohang3112]

@MarcelWilson Last merged PR seems to be in September. Maybe the repo maintainers are taking a break (hopefully temporary!)

[ndepaola]

@sohang3112 you might have more luck switching to selenium's new built-in webdriver manager (functionally equivalent to this library but less buggy in my experience) https://www.selenium.dev/documentation/selenium_manager/#automated-browser-management

switching my project to it was trivial chilli-axe/mpc-autofill#192

[sohang3112]

selenium's new built-in webdriver manager

@ndepaola Thanks - didn't know about this!

[aleksandr-kotlyar]

@sohang3112 this idea is awesome! Thank you for your time and this PR! Sorry but I have no time to check it, can you prove it works by adding some tests please? And also prove that no regression comes with it?

[sohang3112]

@aleksandr-kotlyar Where should I put the tests - in tests folder or tests_xdist? (I didn't really understand the purpose of test_xdist since all 3 files in it have the same test)

And also prove that no regression comes with it?

How should I do that??

[pep8speaks]

Hello @sohang3112! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file webdriver_manager/core/driver_cache.py:

Line 106:80: E501 line too long (95 > 79 characters)
Line 108:80: E501 line too long (116 > 79 characters)

• In the file webdriver_manager/core/os_manager.py:

Line 167:80: E501 line too long (81 > 79 characters)

Comment last updated at 2023-12-02 05:44:23 UTC

[aleksandr-kotlyar]

@aleksandr-kotlyar Where should I put the tests - in tests folder or tests_xdist? (I didn't really understand the purpose of test_xdist since all 3 files in it have the same test)

And also prove that no regression comes with it?

How should I do that??

To /tests/ only would be enough.
All tests should pass.

[sohang3112]

Hi. I'm closing this Pull Request, as there's already a way to do what I wanted which I didn't know before:

from webdriver_manager.firefox import GeckoDriverManager

from webdriver_manager.core.utils import read_version_from_cmd 
from webdriver_manager.core.os_manager import PATTERN

firefox_path = "/usr/bin/firefox-bin-custom"
version = read_version_from_cmd(f"{firefox_path} --version", PATTERN["firefox"])
driver_binary = GeckoDriverManager(version=version).install()