-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest chrome driver version #445
Support latest chrome driver version #445
Conversation
alexander-gridnev
commented
Sep 28, 2022
•
edited
Loading
edited
- addresses the following issue ValueError: There is no such driver by url #443.
- fixes Pipfile ("name" field became required for index definition)
- update tests to support execution on m1/m2 mac CPUs.
cb81f08
to
5c70a59
Compare
Thanks Alexander, this works for my colleague! |
e0249bd
to
6267102
Compare
Thank you Alexander. Any idea when this will be released? Is there a workaround until then? |
Having the same issue, thank you |
I'm also seeing this issue. Thank you for the quick fix, would love to see it released soon! |
@rain01 yeah, latest_release_url it's the url which used to check latest available version (returns string "106.0.5249.61" atm), so, i just use direct link to the commit in requirements files (like this - git+https://github.com/alexander-gridnev/webdriver_manager@62671021ee5456c315d9d0eae3f2428d6cec955f#egg=webdriver-manager) Hey @aleksandr-kotlyar @SergeyPirogov, could you guys review the change? |
@@ -29,10 +30,22 @@ def get_os_type(self): | |||
return os_type | |||
|
|||
if is_arch(os_type): | |||
return f"{os_type.replace('_m1', '')}_m1" | |||
return "mac_arm64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but if it's arch that is not mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous if statement checks "none mac" case, and returns os_type as is.
But yeah, is_arch function is kind of misleading atm, i was even thinking to rename to "is_mac_arch" and add to inside function check if that's mac or not, cause it's always used after is_mac check in current codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
I always wondered, why the function is named is_arch
and it isn't is_arm
? Isn't is_arch
coming from is architecture (which can be any arch)?
Ok will merge it. @alexander-gridnev thank you |
https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip has not been found. but we can find https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac_arm64.zip after this patch was applied, my webdriver manager made a following error Please check this |
@SergeyPirogov can you please release this fix in pypi as soon as possible ? |
Having the same problem here... |
Same issue as well, please assist! |
Hi @Pr0s3lyt3, @ambitionist, could show output of such snippet:
Also, on which macs do you run it? |
Output: I'm using a mac m1 2020 with Monterey 12.6 |
hmm, could you show output |
here is what i see:
|
|
try to uninstall and install current master:
|
I confirm this is what I saw too
But if you do this instead:
then you shall get:
|
Thanks, I needed to also install the "packaging" dependency to make it work but it fixes it! |
* Update the deprecated code Adjusting the code with the new update on webdriver_manager #445: SergeyPirogov/webdriver_manager#445 * Update dolla.py Co-authored-by: staz <74452129+alyanser@users.noreply.github.com>
Can we please release this as asked here as well? |
I'm having this issue as well. @SergeyPirogov could you please tag a release? |
Hello, could you provide a pr with version update to 3.8.4 |
That's normally something that a maintainer does. But if you want that, is there a maintenance branch I can merge into? |
I am still seeing this issue -- ValueError: There is no such driver by url https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip |
Hello guys, any idea on when are we going to release the last version? |
3.8.4 did not fix this for me. |