Progress bar for downloads

[Mandera]

After opening #388 I thought I could try doing it myself, this is the result!

The only modified part is WDMHttpClient.get

• Added tqdm as dependency
• Changed requests.get's stream parameter to True
  • I saw that this was the case some versions ago, hopefully, it's alright to go back to having it enabled again
• The progress bar is only shown if Content-Length exists in the response header and if it's greater than 100
  • Didn't want the progress bar to be shown for the "latest driver version" request which was very small
  • The value 100 should probably not be hard-coded
  • 100 might also not be the ideal default value, I only tried it on the Chrome driver
• Download speed unit is dynamic, I used the parameters from the bytes CLI options
• In my attempt to mess as little as possible with the other code I'm storing the content from the stream to a bytearray
  • This bytearray then replaces the protected attribute _content in the response object
  • Looks pretty safe to do
• I'm not too familiar with logging so not sure how to make the progress bar go through that if necessary
  • Found this on SO anyhow
• Not sure how to make a unit test for this

Here's an example of how it looks

Thank you

[pep8speaks]

Hello @Mandera! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file webdriver_manager/core/http.py:

Line 32:80: E501 line too long (84 > 79 characters)
Line 36:1: W391 blank line at end of file

• In the file webdriver_manager/core/utils.py:

Line 284:80: E501 line too long (81 > 79 characters)
Line 285:80: E501 line too long (96 > 79 characters)
Line 289:80: E501 line too long (114 > 79 characters)

Comment last updated at 2022-07-30 07:39:30 UTC

[Mandera]

• Moved progress bar code to show_download_progress() in utils.py
• Hardcoded the "[WDM] - " prefix for the progress bar as I think making tqdm use the logger's formatting dynamically isn't feasible
• Added tqdm to install_requires in setup.py (In addition to Pipfile) - Is this the right way to do it? Seems strange to define deps in two places

[SergeyPirogov]

Well, I think that this approach shold be just documented. I dont want to add 3rd party dependency and have a progress bar enabled by default

[Mandera]

Yeah makes sense to have it disabled by default, add a parameter progress_bar=False to DriverManager and its subclasses?

Are you open to making tqdm an optional dependency? Such as pip install webdriver-manager[progress-bar] or pip install webdriver-manager[full]
If not I could try writing a simplistic progress bar without 3rd party deps

[SergeyPirogov]

Yeah makes sense to have it disabled by default, add a parameter progress_bar=False to DriverManager and its subclasses?

Are you open to making tqdm an optional dependency? Such as pip install webdriver-manager[progress-bar] or pip install webdriver-manager[full] If not I could try writing a simplistic progress bar without 3rd party deps

Yes, making it optional is a great idea