Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type #249

Merged

Conversation

aleksandr-kotlyar
Copy link
Collaborator

@aleksandr-kotlyar aleksandr-kotlyar commented Oct 16, 2021

@pep8speaks
Copy link

pep8speaks commented Oct 16, 2021

Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 287:80: E501 line too long (105 > 79 characters)
Line 288:80: E501 line too long (103 > 79 characters)
Line 289:80: E501 line too long (105 > 79 characters)

Line 145:80: E501 line too long (140 > 79 characters)

Comment last updated at 2021-10-16 08:58:21 UTC

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #249 (9794a98) into master (007efd8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   88.14%   88.17%   +0.02%     
==========================================
  Files          11       11              
  Lines         464      465       +1     
  Branches       53       52       -1     
==========================================
+ Hits          409      410       +1     
  Misses         37       37              
  Partials       18       18              
Impacted Files Coverage Δ
webdriver_manager/driver.py 95.80% <100.00%> (-0.06%) ⬇️
webdriver_manager/microsoft.py 100.00% <100.00%> (ø)
webdriver_manager/utils.py 74.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007efd8...9794a98. Read the comment docs.

…version and OS type

- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- delete requirements.txt
@aleksandr-kotlyar aleksandr-kotlyar changed the title release 3.5.2 finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type Oct 16, 2021
@SergeyPirogov SergeyPirogov merged commit 7e92270 into SergeyPirogov:master Oct 16, 2021
miguelius pushed a commit to miguelius/webdriver_manager that referenced this pull request Oct 18, 2021
…version and OS type (SergeyPirogov#249)

- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- delete requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants