Skip to content

Commit

Permalink
Fix TypeError when no browser version found (#545)
Browse files Browse the repository at this point in the history
Right now it fails like this:
```
File "/function/code/main.py", line 19, in doit
    installed = manager.install()
   File "/function/code/webdriver_manager/chrome.py", line 39, in install
    driver_path = self._get_driver_binary_path(self.driver)
   File "/function/code/webdriver_manager/core/manager.py", line 33, in _get_driver_binary_path
    file = self._download_manager.download_file(driver.get_driver_download_url())
   File "/function/code/webdriver_manager/drivers/chrome.py", line 45, in get_driver_download_url
    driver_version_to_download = self.get_driver_version_to_download()
   File "/function/code/webdriver_manager/core/driver.py", line 51, in get_driver_version_to_download
    else self.get_latest_release_version()
   File "/function/code/webdriver_manager/drivers/chrome.py", line 71, in get_latest_release_version
    if version.parse(determined_browser_version) >= version.parse("113"):
   File "/function/code/packaging/version.py", line 52, in parse
    return Version(version)
   File "/function/code/packaging/version.py", line 196, in __init__
    match = self._regex.search(version)
```
  • Loading branch information
mskozlova authored Jul 24, 2023
1 parent fa0b673 commit 1a93434
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webdriver_manager/drivers/chrome.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def get_browser_type(self):
def get_latest_release_version(self):
determined_browser_version = self.get_browser_version_from_os()
log(f"Get LATEST {self._name} version for {self._browser_type}")
if version.parse(determined_browser_version) >= version.parse("113"):
if determined_browser_version is not None and version.parse(determined_browser_version) >= version.parse("113"):
return determined_browser_version

latest_release_url = (
Expand Down

0 comments on commit 1a93434

Please sign in to comment.