Skip to content

Commit

Permalink
Add note that users SHOULD use Span creation attributes. (open-teleme…
Browse files Browse the repository at this point in the history
  • Loading branch information
Oberon00 authored and Sergey Kanzhelev committed Feb 18, 2020
1 parent 7915a62 commit c499a47
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions specification/api-tracing.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,15 @@ The API MUST accept the following parameters:
root `Span`. API MAY also have an option for implicit parent context
extraction from the current context as a default behavior.
- [`SpanKind`](#spankind), default to `SpanKind.Internal` if not specified.
- `Attribute`s - similar API with [Span::SetAttributes](#set-attributes). These
attributes will be used to make a sampling decision as noted in [sampling
description](sdk-tracing.md#sampling). Empty list will be assumed if not
specified.
- `Attribute`s - A collection of key-value pairs, with the same semantics as
the ones settable with [Span::SetAttributes](#set-attributes). Additionally,
these attributes may be used to make a sampling decision as noted in [sampling
description](sdk-tracing.md#sampling). An empty collection will be assumed if
not specified.

Whenever possible, users SHOULD set any already known attributes at span creation
instead of calling `SetAttribute` later.

- `Link`s - see API definition [here](#add-links). Empty list will be assumed if
not specified.
- `Start timestamp`, default to current time. This argument SHOULD only be set
Expand Down

0 comments on commit c499a47

Please sign in to comment.