LibWeb: Unify sizing of tracks with spanning and non-spanning items in GFC #18937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Missing some tests here :) |
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
Implements more parts of sizing algorithm for tracks with spanning items to archive parity with implementation for sizing of tracks with non-spanning items.
Since the specifications indicate that the algorithm for sizing tracks without any spanning items is a simplified version of the more general algorithm used for sizing tracks with spanning items, we can reuse the code to size both cases.
github-actions
bot
removed
the
👀 pr-needs-review
|
@kalenikaliaksandr @awesomekling I'm not sure where performance comes in your priorities, but I would like to note that when we implemented the special casing that has been removed in this PR in Taffy (DioxusLabs/taffy#343), time to complete grid layouts dropped by half (from 16ms to 8ms for a nested grid layout containing 10k nodes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new layout tests or changes to existing tests are necessary for this refactor. The refactor aims to address the issue of having separate implementations for sizing tracks with items of span = 1 and items of span > 1. By using the same code for both cases, it will help make progress without writing it twice.