Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 14 create load map #22

Merged
merged 20 commits into from
Oct 25, 2023
Merged

13 14 create load map #22

merged 20 commits into from
Oct 25, 2023

Conversation

cfstcyr
Copy link
Collaborator

@cfstcyr cfstcyr commented Oct 24, 2023

READ THIS BEFORE REVIEW:

What was done:

  • Created models for everything related to map (Position, Intersection, Map, etc.)
  • Created services to load map and handle map data
  • Created IHM elements to load the map
  • Added relation between services and views when adding markers on map

What to review:

  • src/models/map/: Every models in this directory. These are the models for the map.
  • src/services/map/map_loader_service.py: This service's job is to load the map into our models. It reads from an XML and pass the created model to map_service.py.
  • src/services/map/map_service.py: This service's job is to "keep" the information about the map. The map is saved in this service using an observer so that others can subscribe to when a map is loaded or unloaded. This service also handles the map markers. Its job will be to dispatch the computing to place it at the right place on the map, but for now, we just place it where the user clicked.

You can look at the changes in src/views/, but it's really not that important.

What to ignore:

  • Some changes had to be made to the navigation system, basically, the way I implemented it the first time caused circular dependency issues, so I had to change it. It was a lot of small changes so it's really not that interesting to review.

@cfstcyr cfstcyr self-assigned this Oct 24, 2023
This was linked to issues Oct 24, 2023
@cfstcyr cfstcyr merged commit e34a377 into dev Oct 25, 2023
3 checks passed
@cfstcyr cfstcyr deleted the 13-14-create-load-map branch October 25, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE - create LoadMap FE - Create LoadMapView
1 participant