Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/subtask getters #186

Merged
merged 11 commits into from
Oct 2, 2024
Merged

feature/subtask getters #186

merged 11 commits into from
Oct 2, 2024

Conversation

joshua-dean
Copy link
Collaborator

@joshua-dean joshua-dean commented Sep 30, 2024

Add getters for current subtask and subtask key

Description

  • Added .get_current_subtask_key() and .get_current_subtask() on ULabel main object
  • Replaced over 200 instances of previous access pattern

Closes #183.

There's a lot of instances where const subtask is declared when it really should be const subtask_key. I can open an issue to remedy this, or try to tackle all of them in this PR. Let me know.

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

@joshua-dean joshua-dean added the enhancement New feature or request label Sep 30, 2024
@joshua-dean joshua-dean self-assigned this Sep 30, 2024
@joshua-dean joshua-dean marked this pull request as ready for review October 1, 2024 15:09
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as far as i can tell everything still works as expected

@joshua-dean joshua-dean merged commit ee1af99 into main Oct 2, 2024
@joshua-dean joshua-dean deleted the feature/subtask-getters branch October 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current subtask should be a getter
2 participants