Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cancel draw #137

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Fix/cancel draw #137

merged 9 commits into from
Apr 5, 2024

Conversation

TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Apr 5, 2024

Fix/cancel draw

Description

  • Fix bug where vanish mode was disabled during brush/erase mode
  • Align undo behavior for polygons and polylines with that of other annotations (once complete, the undo will delete the entire annotation rather than undoing only the last point)
  • Escape keybind to cancel an in-progress annotation

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

Undo behavior has changed for polygons and polylines such that it is consistent with other annotation types. Once complete, the undo will delete the entire annotation rather than undoing only the last point.

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Apr 5, 2024
@TrevorBurgoyne TrevorBurgoyne merged commit 1c239e6 into main Apr 5, 2024
@TrevorBurgoyne TrevorBurgoyne deleted the fix/cancel-draw branch April 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant