Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WS-436] [WS-441] [WS-442] [WS-468] Fix/erase mode #136

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Mar 22, 2024

Minor Bug Fixes

JIRA

WS-436
WS-441
WS-442
WS-468

Description

  • Fix bug where erase mode could perist when changing annotation mode
  • When user provides an initial_line_size, use that as the default size for new annotations independent of zoom
    • When this argument is not provided, the behavior is unchanged from before (the size of new annotations will still scale with the zoom level).
  • Fix bug where the DELETE_CLASS_ID would show up as an option in the id dialog for polygons and bounding boxes

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

For users who have been providing the initial_line_size argument, new annotations that are drawn will no longer scale with the zoom level, and instead will always default to the provided initial_line_size or the most recent size set via the AnnotationResize toolbox item.

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Mar 22, 2024
@TrevorBurgoyne TrevorBurgoyne changed the title Fix/erase mode [WS-436] [WS-441] [WS-442] [WS-468] Fix/erase mode Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant