20220810 domoticz - experimental branch - PR 3 of 3 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Discord thread starting at https://discord.com/channels/638610460567928832/638610461109256194/1005812386688680006 revealed that the Domoticz would not function properly on a clean install. The symptom was either a 400 or a 404 error, depending on the URL. Three issues identified with existing service definition: 1. Wrong image base. Should be "lscr.io/linuxserver/domoticz". 2. Wrong image tag. Should be "latest". 3. `network_mode: bridge`. It has never been clear what `network_mode: bridge` is intended to do. It is the only container with this option. While it may once have been needed, its presence now appears to prevent the container from responding correctly on port 8083. Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Discord thread starting at
https://discord.com/channels/638610460567928832/638610461109256194/1005812386688680006
revealed that the Domoticz would not function properly on a clean
install. The symptom was either a 400 or a 404 error, depending on the
URL.
Three issues identified with existing service definition:
network_mode: bridge.It has never been clear what
network_mode: bridgeis intended to do.It is the only container with this option. While it may once have been
needed, its presence now appears to prevent the container from
responding correctly on port 8083.
Signed-off-by: Phill Kelley 34226495+Paraphraser@users.noreply.github.com