20211215 nextcloud_db - exposed port - master branch - PR 1 of 3 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Requests [PR387](SensorsIot#387), [PR388](SensorsIot#388), [PR389](SensorsIot#389) added a port mapping of `9322:3306` to facilitate backup and restores - so the routines could determine when the MariaDB service was ready for business. The need for this was superseded by PRs [416](SensorsIot#416), [417](SensorsIot#417) and [418](SensorsIot#418). It is sufficient for backup and restore routines to run the health check and rely on the return status. This PR removes the `9322:3306` as no longer needed. It will also avoid the need to protect the port with an iptables rule in situations where the host is exposed to the network. Documentation also updated. Signed-off-by: Phill Kelley <pmk.57t49@lgosys.com>
Slyke
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests PR387, PR388, PR389 added a port mapping of
9322:3306to facilitate backup and restores - so the routines could determine when the MariaDB service was ready for business.The need for this was superseded by PRs 416, 417 and 418. It is sufficient for backup and restore routines to run the health check and rely on the return status.
This PR removes the
9322:3306as no longer needed. It will also avoid the need to protect the port with an iptables rule in situations where the host is exposed to the network.Documentation also updated.
Signed-off-by: Phill Kelley pmk.57t49@lgosys.com