Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #361: Update error logging #495

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

sukhbeersingh
Copy link
Contributor

@sukhbeersingh sukhbeersingh commented Dec 8, 2019

Issue This PR Addresses
This PR fixes #361 by adding the standard {error} object followed by a message for all log.error calls.

Type of Change

This is an enhancement to standardize the way we log errors, which can be very helpful in debugging if done properly.

Description

This PR changes files that use the log.error functionality.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionalty or configuration variables are added/changed or an explanation of why it does not(if applicable)

Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manekenpix
Copy link
Member

Where's Circle CI?

@sukhbeersingh
Copy link
Contributor Author

The file’s still there in my repo. Don’t know what’s going on

@humphd
Copy link
Contributor

humphd commented Dec 8, 2019

Weird. It's like it stopped at #494 just before this one https://circleci.com/gh/Seneca-CDOT/telescope. Let's see if it rights itself. If not, try pushing another commit to trigger it.

@humphd humphd merged commit 15a67c4 into Seneca-CDOT:master Dec 9, 2019
@sukhbeersingh sukhbeersingh deleted the issue#361 branch December 9, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all log.error() calls to include full error object + message
3 participants