Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #353 Create LoginDiagram.txt #460

Closed
wants to merge 2 commits into from
Closed

Fixes #353 Create LoginDiagram.txt #460

wants to merge 2 commits into from

Conversation

cagomezr
Copy link
Contributor

@cagomezr cagomezr commented Dec 5, 2019

Diagran for enhancement type documentation,

We are creating an ascci diagram for the documentation, this is in a sepparate folder in order to organize our documentation further and keep some part of our code more understandable and easy to understand

this is covered in issue #353

this is a new pull request due to rebase conflicts -153 conflicts- and I rather be safe about it.

the issues in last pull request has been solved and is ready to go

Diagran for  enhancement  type  documentation,

We are  creating an ascci  diagram  for the documentation, this is in a sepparate folder in order to organize our   documentation further and   keep some part of our code more understandable and easy to understand
Diagran for enhancement type documentation,

We are creating an ascci diagram for the documentation, this is in a sepparate folder in order to organize our documentation further and keep some part of our code more understandable and easy to understand

this is covered in issue #353
@cagomezr cagomezr requested a review from Grommers00 December 5, 2019 15:36
Copy link
Contributor

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Markdown vs. Text. This should use proper GitHub Markdown, so it will get rendered properly.

@cindyorangis
Copy link
Contributor

This PR is stale because it has been open for almost two months with no activity. Closing.

@humphd humphd deleted the issue#353 branch February 9, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants