Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch third party images from docker.cdot.systems #3801

Merged
merged 1 commit into from
Feb 15, 2023
Merged

feat: fetch third party images from docker.cdot.systems #3801

merged 1 commit into from
Feb 15, 2023

Conversation

manekenpix
Copy link
Member

@manekenpix manekenpix commented Feb 14, 2023 •
edited
Loading

Description

This PR add changes to take advantage of the recent changes made to docker.cdot.systems here.

Steps to test the PR

N/A

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

humphd
humphd approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's working, despite the e2e failures, which aren't related.

@manekenpix manekenpix self-assigned this Feb 15, 2023
@manekenpix manekenpix added dependencies Pull requests that update a dependency file area: deployment Production or Staging deployment and removed dependencies Pull requests that update a dependency file labels Feb 15, 2023
@manekenpix manekenpix marked this pull request as ready for review February 15, 2023 00:52
@manekenpix manekenpix merged commit c50944b into Seneca-CDOT:master Feb 15, 2023
@manekenpix manekenpix deleted the use-pull-through branch February 15, 2023 00:53
manekenpix added a commit that referenced this pull request Feb 15, 2023
@manekenpix
Revert "feat: fetch third party images from docker.cdot.systems (#3801)"
70063bf 
This reverts commit c50944b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

Assignees

@manekenpix manekenpix

Labels
area: deployment Production or Staging deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manekenpix @humphd