Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove nodejs 14 from the project #3798

Merged
merged 1 commit into from
Jan 31, 2023
Merged

chore: remove nodejs 14 from the project #3798

merged 1 commit into from
Jan 31, 2023

Conversation

manekenpix
Copy link
Member

@manekenpix manekenpix commented Jan 30, 2023 •
edited by shawnyu5
Loading

Description

Node v14 end of life is 2023-04-30 (nodejs releases here), this PR removes all references (package.json files and CI/CD) to v14 in the project, and adds v18.

Steps to test the PR

N/A

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix requested a review from a team January 30, 2023 17:01
@manekenpix manekenpix self-assigned this Jan 30, 2023
@manekenpix manekenpix added the developer experience Helping the Developer Experience label Jan 30, 2023
@manekenpix manekenpix marked this pull request as ready for review January 30, 2023 17:06
@manekenpix manekenpix merged commit 4e73c62 into Seneca-CDOT:master Jan 31, 2023
@manekenpix manekenpix deleted the remove-nodejs-14 branch January 31, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

Assignees

@manekenpix manekenpix

Labels
developer experience Helping the Developer Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manekenpix @humphd