Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline ownership confirmation during sign-up #3775

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

cychu42
Copy link
Contributor

@cychu42 cychu42 commented Dec 1, 2022

Issue This PR Addresses

Fixes #3608

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

The original sign-up process requires users to tick multiple checkboxes to confirm ownership of each account entered. This PR streamlines the process to remove the checkboxes and instead show a line of confirmation text on the review page.
Users can now go to next page without being required to tick the checkboxes.

image
image
image

List of code changes:

  • Delete agreement field from RSSFeedsFormProps and RSSFeeds, in src\web\app\src\components\SignUp\Forms\RSSFeeds.tsx
  • Delete agreement field from src\web\app\src\components\SignUp\Forms\BlogFeeds.tsx and src\web\app\src\components\SignUp\Forms\ChannelFeeds.tsx
  • Delete githubOwnership, blogOwnership, and channelOwnership fields from SignUpForm in src\web\app\src\interfaces\index.ts
  • Delete githubOwnership, blogOwnership, and channelOwnership from src\web\app\src\pages\signup.tsx
  • Delete CheckBoxInput from src\web\app\src\components\SignUp\Forms\GitHubAccount.tsx and src\web\app\src\components\SignUp\Forms\RSSFeeds.tsx
  • Delete code relating to githubOwnership, blogOwnership, and channelOwnership checking from src\web\app\src\components\SignUp\Schema\FormSchema.tsx
  • Delete githubOwnership, blogOwnership, and channelOwnership from src\web\app\src\components\SignUp\Schema\FormModel.tsx
  • Add confirmation text in src\web\app\src\components\SignUp\Forms\Review.tsx

Steps to test the PR

Test this by going through the sign-up process to view the channel page.
During testing, you can use test account user1 with password user1pass.
You can enter any GitHub account name, blog URL, and (optional) Twitch/Youtube channel URL to get through the pages.
For testing, you can use these data:
GitHub Account: cychu42
Blog: https://dev.to/cychu42/
Twitch Channel: https://www.twitch.tv/nl_kripp

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@cychu42 cychu42 marked this pull request as ready for review December 1, 2022 18:36
@cychu42
Copy link
Contributor Author

cychu42 commented Dec 1, 2022

The unit tests all passed. It looks like the e2e tests have issue connecting to http://azure.archive.ubuntu.com/ for setting up the tests.

@humphd
Copy link
Contributor

humphd commented Dec 1, 2022

Re-running failed jobs

@manekenpix manekenpix force-pushed the master branch 17 times, most recently from 94eec21 to e27efa5 Compare December 3, 2022 21:12
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, nice work.

@PedroFonsecaDEV and @DukeManh, if either of you want to review let me know (no pressure). Otherwise I'll merge this week.

@cychu42
Copy link
Contributor Author

cychu42 commented Dec 9, 2022

Thank you!

Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@humphd humphd merged commit db8f43f into Seneca-CDOT:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve User Experience for selecting blog feeds
3 participants