Streamline ownership confirmation during sign-up #3775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #3608
Type of Change
Description
The original sign-up process requires users to tick multiple checkboxes to confirm ownership of each account entered. This PR streamlines the process to remove the checkboxes and instead show a line of confirmation text on the review page.
Users can now go to next page without being required to tick the checkboxes.
List of code changes:
agreement
field fromRSSFeedsFormProps
andRSSFeeds
, insrc\web\app\src\components\SignUp\Forms\RSSFeeds.tsx
agreement
field fromsrc\web\app\src\components\SignUp\Forms\BlogFeeds.tsx
andsrc\web\app\src\components\SignUp\Forms\ChannelFeeds.tsx
githubOwnership
,blogOwnership
, andchannelOwnership
fields fromSignUpForm
insrc\web\app\src\interfaces\index.ts
githubOwnership
,blogOwnership
, andchannelOwnership
fromsrc\web\app\src\pages\signup.tsx
CheckBoxInput
fromsrc\web\app\src\components\SignUp\Forms\GitHubAccount.tsx
andsrc\web\app\src\components\SignUp\Forms\RSSFeeds.tsx
githubOwnership
,blogOwnership
, andchannelOwnership
checking fromsrc\web\app\src\components\SignUp\Schema\FormSchema.tsx
githubOwnership
,blogOwnership
, andchannelOwnership
fromsrc\web\app\src\components\SignUp\Schema\FormModel.tsx
src\web\app\src\components\SignUp\Forms\Review.tsx
Steps to test the PR
Test this by going through the sign-up process to view the channel page.
During testing, you can use test account
user1
with passworduser1pass
.You can enter any GitHub account name, blog URL, and (optional) Twitch/Youtube channel URL to get through the pages.
For testing, you can use these data:
GitHub Account: cychu42
Blog: https://dev.to/cychu42/
Twitch Channel: https://www.twitch.tv/nl_kripp
Checklist