Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telescope Supabase docs #3502

Merged
merged 4 commits into from
Apr 17, 2022
Merged

Conversation

DukeManh
Copy link
Contributor

@DukeManh DukeManh commented Apr 16, 2022

Issue This PR Addresses

Fix #2734

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Apr 16, 2022

@joelazwar
Copy link
Contributor

Thank You for stepping up and actually make this doc!! Looks great and well written :)

also this can close #2966

joelazwar
joelazwar previously approved these changes Apr 17, 2022
Copy link
Contributor

@tcvan0707 tcvan0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! You might need to make some changes.

tcvan0707
tcvan0707 previously approved these changes Apr 17, 2022
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, thank you for this.

src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved

```bash
curl http://localhost/v1/supabase/rest/v1/feeds?select=*&limit=2
-H "apiKey:<ANON_KEY>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works? They don't require you to put it in the Authorization header? Interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWTs are put in Authorization header, so the the equivalent of supabase.auth.setAuth(JWT)

src/web/docusaurus/docs/tools-and-technologies/supabase.md Outdated Show resolved Hide resolved
@DukeManh
Copy link
Contributor Author

@humphd, thank you, ready to be reviewed again.

@DukeManh DukeManh merged commit 6154b26 into Seneca-CDOT:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: supabase Anything related to Supabase type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[X-Post][Satellite] Document JWT_SECRET with more information (README.md) Documentation for Supabase
4 participants