-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix planet to use Supabase, remove feedsUrl/userFeedsUrl from front-end #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to test this:
Now visit http://localhost:9876/planet |
TueeNguyen
previously approved these changes
Apr 12, 2022
DukeManh
reviewed
Apr 12, 2022
Fixed to use the |
DukeManh
requested changes
Apr 12, 2022
Co-authored-by: Duc Manh <51073515+DukeManh@users.noreply.github.com>
DukeManh
approved these changes
Apr 12, 2022
JerryHue
approved these changes
Apr 12, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3463. This updates the
planet
service to use Supabase for the feeds info vs. Redis (cc @TueeNguyen, you can steal my code for getting author names for the parser, and @DukeManh is going to turn this into a stored procedure in the future).I've also removed the unneeded
feedsUrl
anduserFeedsUrl
from the front-end.@JerryHue After this I'm not sure if anything is using
posts/feeds
anymore.