Loading post for mobile alpha version: #3420
Conversation
|
|
|
@tpmai22 Oh wait, I almost have a PR for this. Mine is like 99% done but for now it will just load the first page of Posts (not infinite). I can work on other stuff of the posts component since it's huge. here is my work |
| minHeight: 300, | ||
| }, | ||
| title: { | ||
| '-webkit-box-orient': 'vertical', |
There was a problem hiding this comment.
I have tested your PR. The some of the CSS properties will not work in React Native like webkit, overflow, letterSpacing or units like em, rem won't work either. I tested this PR using my android emulator of Android studio and I had to chance some styling properties to make it work. The Posts timeline is working fine
There was a problem hiding this comment.
@nguyenhung15913 feel free to push the PR or if you want you can file follow up issues with the features that you have implemented
|
@Kevan-Y @TueeNguyen any opinion ? |
|
Other than those comments, good use of |
|
Since this one is about loading posts only, and it working fine on fetching the posts, I think we can rebase and merge. Then based on this, I will create another PR for the styling that is compatible for mobile app. |
|
I just fix all the syling issues @nguyenhung15913 @TueeNguyen @DukeManh @Kevan-Y I think we are good to go |
. Basic style for post . Loading post using FlatList Co-author: Duke Manh <manhducdkcb@gmail.com>
Closes #2857
. Basic style for post
. Loading post using FlatList
Co-author: Duke Manh manhducdkcb@gmail.com
Issue This PR Addresses
Type of Change
Description
Loading
postsforalphaversion in ourmobileapp homepageSteps to test the PR
Prefer to use Gitpod which make ease in reviewing this PR.
cd src/mobilepnpm startChecklist
Android.Emulator.-.Pixel_4_API_32_5554.2022-04-12.18-19-04.mp4