Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author autocomplete query unit tests in Search #3417

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

RC-Lee
Copy link
Contributor

@RC-Lee RC-Lee commented Apr 7, 2022

Issue This PR Addresses

fixes #3225

Type of Change

Add unit tests for autocomplete query

Description

Steps to test the PR

pnpm test search

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not

@gitpod-io
Copy link

gitpod-io bot commented Apr 7, 2022

@RC-Lee RC-Lee self-assigned this Apr 7, 2022
@humphd humphd added this to the 3.0 Release milestone Apr 7, 2022
TueeNguyen
TueeNguyen previously approved these changes Apr 7, 2022
Copy link
Contributor

@TueeNguyen TueeNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll come back and see there are things to improve. Looks good for now

@humphd
Copy link
Contributor

humphd commented Apr 7, 2022

Can we rebase this on top of all the other PRs that just landed?

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@RC-Lee RC-Lee merged commit 884a210 into Seneca-CDOT:master Apr 8, 2022
@RC-Lee RC-Lee deleted the issue#3225 branch July 10, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Search Service and tests to implement Autocomplete for Authors
4 participants