Improve parser's e2e test #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TueeNguyen
commented
Apr 1, 2022
| @@ -58,10 +58,10 @@ const processFeeds = (feeds) => { | |||
| */ | |||
| const processAllFeeds = async () => { | |||
| try { | |||
| // Get an Array of Feed objects from the wiki feed list and Redis | |||
| const [all, wiki] = await Promise.all([Feed.all(), getWikiFeeds()]); | |||
There was a problem hiding this comment.
Feed.all() and getWikiFeeds() each returns all feeds => Feed.all() not needed and easier to test
TueeNguyen
commented
Apr 1, 2022
| url: 'http://www.hodgin.ca/?feed=rss2&cat=4', | ||
| }, | ||
| ]; | ||
| jest.mock('../../src/utils/wiki-feed-parser', () => jest.fn()); |
There was a problem hiding this comment.
Tells The mock factory returns a mocked function so it wouldn't look for __mocks__
TueeNguyen
commented
Apr 1, 2022
| const valid = [ | ||
| { | ||
| author: 'Tue Nguyen', | ||
| url: 'http://localhost:8888/feed.xml', |
There was a problem hiding this comment.
Uses feed.xml from test-web-content instead of doing real network request
| }, | ||
| { | ||
| author: 'Jane Doe', | ||
| url: 'https://janehasinvalidfeed.com/feed', |
There was a problem hiding this comment.
these urls don't exist/are invalid => response is fast shouldn't affect test's time
TueeNguyen
force-pushed
the
parser-tests-2
branch
from
c23a74b to
f60bc91
Compare
|
|
humphd
previously approved these changes
Apr 1, 2022
| @@ -94,6 +94,7 @@ services: | |||
| - elasticsearch | |||
| - traefik | |||
| - redis | |||
| restart: unless-stopped | |||
This was referenced Apr 5, 2022
menghif
previously approved these changes
Apr 5, 2022
TueeNguyen
force-pushed
the
parser-tests-2
branch
from
9044a99 to
5f41574
Compare
TueeNguyen
force-pushed
the
parser-tests-2
branch
from
5f41574 to
2876e00
Compare
* Use blog from test-web-content * Change invalid url * Specify jest.mock() factory to return mocked function => to not look for __mocks__
TueeNguyen
force-pushed
the
parser-tests-2
branch
from
2876e00 to
005a92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #3369
Fixes #3369
Type of Change
Description
Steps to test the PR
pnpm ipnpm services:startpnpm jest:e2e src/api/parserChecklist