You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation Update: Change which improves documentation
UI: Change which improves UI
Description
In #2617 we added an advanced route. The advanced route is more flexible for search terms and capabilities. In this PR I changed the route used in the search results so that we use the new "advanced" route. In another PR I will clean up the regular search as we are now leveraging the more advanced route - and will be the main route meaning no more /advanced it will be /
Go to search and select author search an author - look in the network tab for dev tools, you will see the results coming from the new route.
Do the same with posts.
Checklist
Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)
Is this PR needed? Cause I noticed you have SearchResults.tsx changed in #3164 as well
This is the smaller version of 3164.... This PR just changes the route to use, the other PR also ends up changing the route because we clean up all the other route and make advanced the main route.
Is this PR needed? Cause I noticed you have SearchResults.tsx changed in #3164 as well
This is the smaller version of 3164.... This PR just changes the route to use, the other PR also ends up changing the route because we clean up all the other route and make advanced the main route.
It still doesn't make sense to me why we can't do the change in just one PR.
I'd like the opinion of another reviewer.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmasiaNalbandian
force-pushed
the
iss-2618
branch
from
Issue This PR Addresses
Fixes #2618
Type of Change
Description
In #2617 we added an advanced route. The advanced route is more flexible for search terms and capabilities. In this PR I changed the route used in the search results so that we use the new "advanced" route. In another PR I will clean up the regular search as we are now leveraging the more advanced route - and will be the main route meaning no more
/advancedit will be/Steps to test the PR
cp config/env.development .envdocker-compose --env-file ./config/env.development up --build search elasticsearch redis posts nginx planetChecklist