-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mobile deployment #2986
Merged
Merged
fix mobile deployment #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[19:46:26] Building optimized bundles and generating sourcemaps...
[19:46:28] Starting Metro Bundler
[19:46:39] Unrecognized event: {"type":"transformer_load_started"}
[19:46:39] Unrecognized event: {"type":"transformer_load_done"}
[19:46:39] Started Metro Bundler
[19:46:39] Cannot delete property 'resolveRequest' of #<Object>
[19:46:39] TypeError: Cannot delete property 'resolveRequest' of #<Object>
at /home/runner/work/telescope/telescope/src/mobile/node_modules/@rnx-kit/metro-resolver-symlinks/lib/index.js:[13](https://github.com/Seneca-CDOT/telescope/runs/5252776336?check_suite_focus=true#step:7:13):9
at Object.resolve (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro-resolver/src/resolve.js:31:12)
at ModuleResolver.resolveDependency (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:115:31)
at DependencyGraph.resolveDependency (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/node-haste/DependencyGraph.js:231:43)
at Object.resolve (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/lib/transformHelpers.js:129:24)
at resolve (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/DeltaBundler/traverseDependencies.js:396:33)
at /home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/DeltaBundler/traverseDependencies.js:412:26
at Array.reduce (<anonymous>)
at resolveDependencies (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/DeltaBundler/traverseDependencies.js:411:33)
at processModule (/home/runner/work/telescope/telescope/src/mobile/node_modules/metro/src/DeltaBundler/traverseDependencies.js:[14](https://github.com/Seneca-CDOT/telescope/runs/5252776336?check_suite_focus=true#step:7:14)0:31)
Error: Process completed with exit code 1.
What's up with that?
I think this is because of this |
* Fixes dependencies version issue * Remove metro.config.js
Kevan-Y
force-pushed
the
fix-mobile-deployment
branch
from
February 18, 2022 21:10
265b976
to
aa22acb
Compare
humphd
approved these changes
Feb 18, 2022
tcvan0707
approved these changes
Feb 18, 2022
DukeManh
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes: #2732
Type of Change
Description
Added missing dependency for mobile deployment.
Enable cache for Expo to reduce the time of downloading Expo. see
At the same time fixing dependencies version issue based on
expo doctor
command. seeRemoved
metro.config.js
since dependenciesrequire('@rnx-kit/metro-resolver-symlinks');
andrequire('@rnx-kit/metro-config');
causing issue during deployment. And also those wasn't require for our app to run.Checklist