Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Base UI library installed #2783

Closed
wants to merge 4 commits into from

Conversation

aserputov
Copy link
Contributor

@aserputov aserputov commented Jan 31, 2022

Issue This PR Addresses

Fixes: #2730

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Native Base UI library installed for mobile application.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Jan 31, 2022

@@ -12,10 +12,12 @@
"dependencies": {
"expo": "44.0.5",
"expo-status-bar": "1.2.0",
"native-base": "^3.3.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin dependency

@TueeNguyen
Copy link
Contributor

Can you explain the changes in metro.config.js

@aserputov
Copy link
Contributor Author

aserputov commented Jan 31, 2022

@TueeNguyen yes. Here is the link about the bug

@AmasiaNalbandian
Copy link
Contributor

@aserputov Can you let us know what happened? Would be good to know in future if we try to use this again. I don't understand the bug to be honest.

@aserputov
Copy link
Contributor Author

@AmasiaNalbandian link

@AmasiaNalbandian
Copy link
Contributor

The PR is being closed because React Native essentially has too many bugs to try and work around, and we have decided it will hinder our progress to have a UI library for 2.6. There seems to be a collective decision to try another package, and that is the direction we are headed in #2730 the issue to install a UI package for RN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native: Get UI library installed
3 participants