-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2671: Add vite to dashboard #2763
Fixes #2671: Add vite to dashboard #2763
Conversation
9500da3
to
b721f06
Compare
b721f06
to
46ccbeb
Compare
46ccbeb
to
a1be71c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! I'm so excited to see this coming along.
a1be71c
to
bd40bef
Compare
bd40bef
to
6f7d6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice feature.
6f7d6ad
to
5af9c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fantastic |
I was expecting the staging to break, too bad. |
Just realize if something goes wrong, the logger will bring down the whole server telescope/src/api/status/src/server.js Line 127 in ed156ac
|
Why will that bring down the whole server? |
Shouldn't it be |
Ah, yes. Can you fix in a follow-up? |
Issue This PR Addresses
Closes #2671
Type of Change
Description
Bundle client-side javascript with Vite. This also allows mixing
.cjs
and.js
.Changelog
Test plan
pnpm dev
Checklist