Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YouTube channel test case for feed discovery service #2723

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Add YouTube channel test case for feed discovery service #2723

merged 1 commit into from
Jan 25, 2022

Conversation

JerryHue
Copy link
Contributor

Issue This PR Addresses

Fixes #2675.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI
  • Test: Change that adds test cases

Description

This PR adds a test case to ensure that the feed discovery microservice works with YouTube URLs.

Checklist

  • Quality: This PR builds and passes our npm test and works locally.
  • Tests: This PR includes thorough tests or an explanation of why it does not.
  • Screenshots: This PR does not include screenshots as it does not modify UI.
  • Documentation: This PR does not include expanded documentation, because it does not add user-facing features.

@JerryHue JerryHue added area: back-end type: test Creation and development of test labels Jan 24, 2022
@JerryHue JerryHue self-assigned this Jan 24, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2022

AmasiaNalbandian
AmasiaNalbandian approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@AmasiaNalbandian AmasiaNalbandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just rebase please! :)

@humphd humphd merged commit 3ead118 into Seneca-CDOT:master Jan 25, 2022
@humphd humphd added this to the 2.6 Release milestone Jan 25, 2022
@JerryHue JerryHue mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmasiaNalbandian AmasiaNalbandian AmasiaNalbandian approved these changes

@humphd humphd humphd approved these changes

@DukeManh DukeManh Awaiting requested review from DukeManh

Assignees

@JerryHue JerryHue

Labels
area: back-end type: test Creation and development of test
Projects
None yet
Milestone
2.6 Release
Development

Successfully merging this pull request may close these issues.

Add support for YouTube feed discover to feed-discovery service
3 participants
@JerryHue @humphd @AmasiaNalbandian