Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title container overflow fixed #2668

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Title container overflow fixed #2668

merged 1 commit into from
Jan 18, 2022

Conversation

TDDR
Copy link
Contributor

@TDDR TDDR commented Jan 18, 2022

Fixes #2583

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

The original PR that this is related to can be found here. The original author has moved on from the project. The only thing holding this up from being integrated is a rebase.

Capture

image

I have rebased, tested, and would like some re-reviews before merging.

@TDDR TDDR added this to the 2.5 Release milestone Jan 18, 2022
@TDDR TDDR self-assigned this Jan 18, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 18, 2022

humphd
humphd previously approved these changes Jan 18, 2022
DukeManh
DukeManh previously approved these changes Jan 18, 2022
Kevan-Y
Kevan-Y previously approved these changes Jan 18, 2022
Copy link
Contributor

@Kevan-Y Kevan-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TDDR TDDR merged commit f4639d5 into Seneca-CDOT:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title container floating with some space, and overflow with the scroll on mobile view.
5 participants