Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest satellite version #2664

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

DukeManh
Copy link
Contributor

@DukeManh DukeManh commented Jan 18, 2022

This changes the Satellite version from 1.17 to 1.x. We manage Satellite ourselves so it's safe to not pin it and let ppm install the latest minor/patch if any.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@DukeManh DukeManh added the dependencies Pull requests that update a dependency file label Jan 18, 2022
@DukeManh DukeManh self-assigned this Jan 18, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 18, 2022

humphd
humphd previously approved these changes Jan 18, 2022
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to say you missed the autodeployment server, but it already does this

"@senecacdot/satellite": "^1.x",

@DukeManh
Copy link
Contributor Author

Just rebased.

but it already does this

Did Renovate miss this when it was pinning dependencies?

@DukeManh DukeManh requested a review from humphd January 18, 2022 00:40
@humphd
Copy link
Contributor

humphd commented Jan 18, 2022

Not sure, I wonder if it did.

@TueeNguyen
Copy link
Contributor

1 question, satellite in src/package.json will be pinned to 1.17 when my #2615 gets merged? And then we're gonna change it to 1.x right?

@DukeManh
Copy link
Contributor Author

Yeah, It depends on which one gets merged first. It'll be best that you also use ^1.x in your PR so there are no conflicts.
Remember to run pnpm install after the change.

@TueeNguyen
Copy link
Contributor

Yup, I'll change it to 1.x for less work.

@DukeManh
Copy link
Contributor Author

Renovate doesn't like autodeployment, no dependencies were pinned there.

https://github.com/Seneca-CDOT/telescope/blob/4fa446171c1ee30b0ddab49961efcb6adafe1f81/tools/autodeployment/package.json

@DukeManh DukeManh merged commit 837a847 into Seneca-CDOT:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants