Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed justify to justifyContent instead #2552

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Changed justify to justifyContent instead #2552

merged 1 commit into from
Dec 1, 2021

Conversation

nguyenhung15913
Copy link
Contributor

Issue This PR Addresses

Fixes #2550

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • Changed justify to justifyContent to needed files.
  • Note: In development, my change did not break anything and the site still worked.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 30, 2021

Copy link
Contributor

@HyperTHD HyperTHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you're missing one file.

<Grid container justify="center">

HyperTHD
HyperTHD previously approved these changes Dec 1, 2021
manekenpix
manekenpix previously approved these changes Dec 1, 2021
DukeManh
DukeManh previously approved these changes Dec 1, 2021
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@humphd
Copy link
Contributor

humphd commented Dec 1, 2021

@nguyenhung15913 please squash this so we can merge it.

  *Changed justify to justifyContent instead
  *Fix in src/web/src/components/Posts/Post.tsx
@humphd humphd merged commit 2359565 into Seneca-CDOT:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

justify in Grid is deprecated, use justifyContent instead
5 participants