-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API status to the new dashboard #2551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the status page showing up if it's not running? It gets hosted by that server. |
cc @DukeManh for gitpod wisdom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on Gitpod when I run npm run dev
from src/api/status
.
I think the variable naming can be better
Ignore the approval, misclick. Need to fix what I mentioned above |
5a54a5c
to
5843f4a
Compare
5843f4a
to
84cae98
Compare
84cae98
to
8cbccc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice enhancement, bonus for being responsive as well 🙌.
@Kevan-Y can you rebase to pick up the change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use the URL the page is loaded on to figure it out, i.e., https://dev.api.telescope.cdot.systems/v1/status (staging) vs https://api.telescope.cdot.systems/v1/status (production). We can't access env vars in the dashboard. |
Using URL will work but not on Gitpot since they are using another URL. |
When we fix #2553 we can do this server side. |
Ok sure, I will leave it like that for now and when working on #2553 I will do it to show only staging/production |
8cbccc2
to
ec77044
Compare
This is failing prettier |
d3c87dc
to
d410f97
Compare
d410f97
to
d526224
Compare
d526224
to
8590481
Compare
8590481
to
07d2a7e
Compare
How can I test this PR to make sure it works? The services seem to not be able to appear despite running. Tried on both gitpod and locally by pulling this PR @Kevan-Y |
@HyperTHD , to run it, you will have to go to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done👍.
Issue This PR Addresses
Fixes #2418
Type of Change
Description
rec.mp4
Checklist