Issue 2525: Fix lint errors

[DukeManh]

Issue This PR Addresses

Fixes #2525

This fixes some linting errors that were left out due to Eslint not being provided with a target files pattern.

These are some common errors in the code.

1. Using <a target=“_blank”> without rel=“referrer” is a security risk
2. Empty components are self-closing
3. Prevent invalid characters from appearing in markup
4. No useless escape
5. Disallow continue statements
6. Avoid for..of loop in favor of array iterator
7. Consistent return, either always or never
8. No restricted globals
9. No use before define
10. No multiple chained assignment
11. No unused variables
12. React Hooks must not be called conditionally

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[gitpod-io]

[humphd]

Looks great, a couple things.

[Andrewnt219]

Good job, that's a lot of work done, One question: is it an eslint rule to have a return In all functions?

[DukeManh]

@Andrewnt219

One question: is it an eslint rule to have a return In all functions?

It's this rule: https://eslint.org/docs/rules/consistent-return#require-return-statements-to-either-always-or-never-specify-values-consistent-return

So basically, we're required to either have no return or return something in every branch of the function.

[Andrewnt219]

So basically, we're required to either have no return or return something in every branch of the function.

I see. Because the PR changes functions that return void to return a value anyway. It isn't a problem though, maybe it's better to be explicit like this.

[Andrewnt219]

LGTM.

[humphd]

Epic. Thank you for a) noticing this; b) fixing it.