Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu duplication edited #2530

Merged
merged 1 commit into from
Nov 28, 2021
Merged

menu duplication edited #2530

merged 1 commit into from
Nov 28, 2021

Conversation

suhhee1011
Copy link
Contributor

@suhhee1011 suhhee1011 commented Nov 28, 2021

issue #2527

This PR fixes #2527

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • Remove duplication of the sidebar menu items.
    image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 28, 2021

Copy link
Contributor

@Kevan-Y Kevan-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperTHD
Copy link
Contributor

@suhhee1011 Please, please, link the issue you're resolving when making your PR, so that the issue auto-closes when your PR gets merged. Saves us a lot of trouble in the future

@HyperTHD HyperTHD merged commit a55973d into Seneca-CDOT:master Nov 28, 2021
@Kevan-Y Kevan-Y assigned suhhee1011 and unassigned Andrewnt219 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Under the telescope links on the Sidebar, the menu displays duplicated
4 participants