-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2486: build log for autodeployment is not working #2514
Fix #2486: build log for autodeployment is not working #2514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing to see!
const res = await fetch(autodeploymentUrl('status')); | ||
const res = await fetch(autodeploymentUrl('status'), { | ||
headers: { | ||
'Cache-Control': 'no-cache', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to happen on the response vs. request. Do this in the autodeployment server here: https://github.com/Seneca-CDOT/telescope/blob/master/tools/autodeployment/builds.js#L100-L129
You can add this to each of those before you send the result:
res.setHeader('Cache-Control', 'no-cache');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: this can (and probably should) happen in a separate PR so we don't block this work. I would just remove the bit above to add headers here for now, and do a second PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll make another PR today.
22d4233
to
b404e42
Compare
b404e42
to
72f4eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andrewnt219 nice job, go ahead and merge this yourself
Should have done a "squash and merge". "Rebase and merge" took my commit as a title instead of the PR's title. |
Issue This PR Addresses
Fixes #2486
Type of Change
Description
Test plan
npm run dev
Checklist