issue-2423: Added state to store student quote #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AmasiaNalbandian
force-pushed
the
issue-2423
branch
from
c388d19 to
fb8a792
Compare
humphd
requested changes
Nov 22, 2021
src/web/src/components/Banner.tsx
Outdated
| export default function Banner({ onVisibilityChange }: BannerProps) { | ||
| const classes = useStyles(); | ||
| const [gitInfo, setGitInfo] = useState({ | ||
| gitHubUrl: '', | ||
| sha: '', | ||
| version: '', | ||
| }); | ||
| const studentQuote = getQuote(); | ||
| const [studentQuote] = useState(() => quotes[Math.floor(Math.random() * quotes.length)]); |
There was a problem hiding this comment.
Let's consider doing what @DukeManh suggested and move this out of the component. Put it on line 113 above and do:
const studentQuote = quotes[Math.floor(Math.random() * quotes.length)]);Then you can use it in the component, but it shouldn't change its value on re-render.
There was a problem hiding this comment.
Perfect. I tried the solution but didn't quite understand we had to move it out, and it had not worked. This works now! Thank you.
removed states, and kept const for student quotes
AmasiaNalbandian
force-pushed
the
issue-2423
branch
from
48560a8 to
29a5431
Compare
DukeManh
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
fixes #2423
Type of Change
This PR adds the sets a state for the student quote, so that when you scroll on the page, it doesn't grab a new quote to display.
Description
Checklist