Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2389 #2508

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Issue 2389 #2508

merged 2 commits into from
Nov 22, 2021

Conversation

LuigiZaccagnini
Copy link
Contributor

#2389 Outdated dependencies for package.json in Next.js directory

fixes #2389

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Updated the outdated packages in src/web.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 22, 2021

Qiwen-Yu
Qiwen-Yu reviewed Nov 22, 2021
View reviewed changes
Copy link
Contributor

@Qiwen-Yu Qiwen-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v12.0.4 is the most updated version of next/mdx

src/web/package.json
@@ -12,7 +12,7 @@
"@fontsource/spartan": "^4.2.2",
"@material-ui/core": "^4.12.3",
"@material-ui/icons": "^4.11.2",
"@next/mdx": "^11.1.0",
"@next/mdx": "^12.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@humphd humphd merged commit 4597627 into Seneca-CDOT:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qiwen-Yu Qiwen-Yu Qiwen-Yu left review comments

@humphd humphd humphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated dependencies for package.json in Next.js directory
3 participants
@LuigiZaccagnini @humphd @Qiwen-Yu