Adding posts count to dashboard #2476

nguyenhung15913 · 2021-11-16T13:40:36Z

Issue This PR Addresses

Type of Change

Bugfix: Change which fixes an issue
New Feature: Change which adds functionality
Documentation Update: Change which improves documentation
UI: Change which improves UI

Description

Added cors to Satellite options at src/api/posts/src/index.js to expose x-total-count header.
Added a component to show posts count at src/api/status/public/index.html
Added postCounts.js at src/api/status/public to fetch and get the total of posts
Added host API to connectSrc of Satellite options, and cors at src/api/status/src/server.js

Note: I worked with postsCount.js locally using fetch to get the x-total-count header from https://localhost/v1/posts and it worked. However, with https://dev.api.telescope.cdot.systems/v1/posts, response.headers.get(x-total-count) will return null.

To test locally:

In src/api/status/env.local, include API_HOST=http://localhost/v1/posts
Comment on <base href="/v1/status/" /> in src/api/status/public/index.html (This line however is required in production)
add process.env.API_HOST to connectSrc in src/api/status/src/server.js
Change fetch url to 'http://localhost/v1/posts' instead in src/api/status/public/js/post/index.js
Run posts service in the root directory npm run services:start posts
Run npm run dev in src/api/status
Here is the screenshot of working posts count:

Checklist

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

gitpod-io · 2021-11-16T13:40:39Z

menghif

I'm getting Total Posts: N/A when running this. Is there something I need to change before running it?

src/api/status/src/server.js

src/api/status/public/index.html

src/api/status/public/postsCount.js

src/api/status/src/server.js

src/api/status/env.local

nguyenhung15913 · 2021-11-17T17:16:40Z

I'm getting Total Posts: N/A when running this. Is there something I need to change before running it?

Hi Mengi, you should change the URL in the fetch in postsCount.js to https://localhost/v1/posts. run npm run services:start posts in the root folder. This will resolve the issue. This is because as I mentioned, It only worked when you work locally.

menghif

File name should be changed to: posts-count.js

src/api/status/public/index.html

humphd · 2021-11-18T13:14:39Z

This needs a rebase

Andrewnt219

Can you include a screenshot of your work in the PR?

src/api/status/public/index.html

src/api/status/public/js/posts-count.js

src/api/status/public/index.html

src/api/status/public/js/posts-count.js

src/api/posts/package.json

src/api/status/env.local

src/api/status/public/index.html

src/api/status/public/js/post/index.js

src/api/status/public/script.js

src/api/status/public/js/post/index.js

humphd · 2021-11-20T18:09:58Z

You need to revert the changes I mentioned, so that it can pull in the proper ones when you rebase onto master.

Andrewnt219

The rebase is correct now, I tested on local but the "http://localhost/v1/posts" return an empty array (probably not your fault). Other than that, everything is great.

Andrewnt219 · 2021-11-20T20:39:33Z

src/api/status/public/index.html

@@ -1307,5 +1328,6 @@ <h6 class="mt-3">Thank you for sharing!</h6>
    <!-- Telescope JS Files -->
    <script src="js/github-stats.js"></script>
    <script src="js/feed/index.js"></script>
+    <script type="module" src="js/index.js"></script>


@nguyenhung15913 this should be changed to js/pages/dashboard.js.

EDIT: can you also export the functions in github-stats.js and feed/index.js, add them to the load even of js/pages/dashboard.js just like your function?

Andrewnt219

Good to go, just revert the unnecessary change and squash all the commits.

src/api/status/public/pages/build.html

tatus

Andrewnt219

The rebase went wrong again...

Andrewnt219 · 2021-11-21T00:28:01Z

config/env.development

@@ -18,7 +18,7 @@ TELESCOPE_HOST=http://localhost:3000

 # The host where all the microservices run (e.g., http://localhost)
 # NOTE: if you change this, change all other occurrences below too.
-API_HOST=localhost
+API_HOST=http://localhost


docker/docker-compose.yml

Andrewnt219 · 2021-11-21T00:28:16Z

package.json

@@ -82,8 +82,8 @@
    "opml-generator": "1.1.1",
    "passport": "0.4.1",
    "passport-saml": "3.1.2",
-    "pino": "7.3.0",
-    "pino-elasticsearch": "6.2.0",
+    "pino": "6.11.2",


src/api/status/env.local

rebased Make functions more precise Fixed PR commit before rebasing added files back after aborting rebase commit after rebase final fix update package.json of posts commit b4 rebase commit 2 fixed before rebase

src/api/status/public/js/pages/dashboard.js

src/api/status/src/server.js

Andrewnt219

Great work!

I tested locally and this should be ready to merge @humphd.

humphd · 2021-11-21T16:22:54Z

src/api/status/public/js/pages/dashboard.js

+import { getFeedCount } from '../feed/index.js';
+import { getGitHubData } from '../github-stats.js';
+
+window.addEventListener('load', (event) => {


Minor nit: event isn't used, you should remove it.

vercel bot deployed to Preview November 16, 2021 13:40 View deployment

humphd requested review from menghif, Andrewnt219 and suhhee1011 November 16, 2021 16:09

menghif reviewed Nov 16, 2021

View reviewed changes

src/api/status/src/server.js Outdated Show resolved Hide resolved

Andrewnt219 suggested changes Nov 16, 2021

View reviewed changes

src/api/status/env.local Outdated Show resolved Hide resolved

vercel bot deployed to Preview November 17, 2021 17:38 View deployment

menghif requested changes Nov 17, 2021

View reviewed changes

src/api/status/public/index.html Outdated Show resolved Hide resolved

vercel bot deployed to Preview November 18, 2021 15:56 View deployment

vercel bot deployed to Preview November 18, 2021 16:01 View deployment

vercel bot deployed to Preview November 18, 2021 16:11 View deployment

humphd requested review from Andrewnt219, menghif and tuanthanh2067 November 18, 2021 16:52

Andrewnt219 suggested changes Nov 18, 2021

View reviewed changes

src/api/status/public/index.html Show resolved Hide resolved

src/api/status/public/js/posts-count.js Outdated Show resolved Hide resolved

src/api/status/public/js/posts-count.js Outdated Show resolved Hide resolved

menghif requested changes Nov 18, 2021

View reviewed changes

src/api/status/public/index.html Show resolved Hide resolved

tuanthanh2067 reviewed Nov 18, 2021

View reviewed changes

src/api/status/public/js/posts-count.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview November 19, 2021 00:57 View deployment

nguyenhung15913 requested review from menghif, Andrewnt219, humphd and tuanthanh2067 November 19, 2021 00:58

vercel bot deployed to Preview November 19, 2021 01:00 View deployment

humphd requested changes Nov 19, 2021

View reviewed changes

vercel bot deployed to Preview November 19, 2021 01:49 View deployment

tuanthanh2067 reviewed Nov 19, 2021

View reviewed changes

src/api/status/public/js/post/index.js Outdated Show resolved Hide resolved

src/api/status/public/js/post/index.js Outdated Show resolved Hide resolved

src/api/status/public/js/post/index.js Outdated Show resolved Hide resolved

nguyenhung15913 added 2 commits November 20, 2021 13:20

commit b4 revert

79fe7c6

This reverts commit 4108258.

1e09729

vercel bot deployed to Preview November 20, 2021 18:34 View deployment

vercel bot deployed to Preview November 20, 2021 18:46 View deployment

vercel bot deployed to Preview November 20, 2021 18:51 View deployment

nguyenhung15913 requested review from humphd and Andrewnt219 November 20, 2021 19:00

Andrewnt219 suggested changes Nov 20, 2021

View reviewed changes

vercel bot deployed to Preview November 20, 2021 21:25 View deployment

vercel bot deployed to Preview November 20, 2021 21:28 View deployment

nguyenhung15913 requested a review from Andrewnt219 November 20, 2021 21:28

Andrewnt219 suggested changes Nov 20, 2021

View reviewed changes

src/api/status/public/pages/build.html Outdated Show resolved Hide resolved

Andrewnt219 suggested changes Nov 20, 2021

View reviewed changes

tatus Outdated Show resolved Hide resolved

vercel bot deployed to Preview November 20, 2021 23:29 View deployment

vercel bot deployed to Preview November 21, 2021 00:10 View deployment

Andrewnt219 suggested changes Nov 21, 2021

View reviewed changes

All commits

a68155d

rebased Make functions more precise Fixed PR commit before rebasing added files back after aborting rebase commit after rebase final fix update package.json of posts commit b4 rebase commit 2 fixed before rebase

vercel bot deployed to Preview November 21, 2021 01:11 View deployment

deleted tatus file

74a795c

vercel bot deployed to Preview November 21, 2021 01:14 View deployment

nguyenhung15913 requested a review from Andrewnt219 November 21, 2021 01:15

Andrewnt219 suggested changes Nov 21, 2021

View reviewed changes

src/api/status/public/js/pages/dashboard.js Outdated Show resolved Hide resolved

src/api/status/src/server.js Outdated Show resolved Hide resolved

fix PR with adding .js extension

3ed4392

vercel bot deployed to Preview November 21, 2021 02:47 View deployment

nguyenhung15913 requested a review from Andrewnt219 November 21, 2021 02:47

Andrewnt219 approved these changes Nov 21, 2021

View reviewed changes

humphd approved these changes Nov 21, 2021

View reviewed changes

humphd merged commit d7241b0 into Seneca-CDOT:master Nov 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding posts count to dashboard #2476

Adding posts count to dashboard #2476

nguyenhung15913 commented Nov 16, 2021 •

edited

Loading

gitpod-io bot commented Nov 16, 2021

menghif left a comment

nguyenhung15913 commented Nov 17, 2021

menghif left a comment

humphd commented Nov 18, 2021

Andrewnt219 left a comment

humphd commented Nov 20, 2021

Andrewnt219 left a comment •

edited

Loading

Andrewnt219 Nov 20, 2021 •

edited

Loading

Andrewnt219 left a comment

Andrewnt219 left a comment

Andrewnt219 Nov 21, 2021

Andrewnt219 Nov 21, 2021

Andrewnt219 left a comment

humphd Nov 21, 2021

Adding posts count to dashboard #2476

Adding posts count to dashboard #2476

Conversation

nguyenhung15913 commented Nov 16, 2021 • edited Loading

Issue This PR Addresses

Type of Change

Description

Checklist

gitpod-io bot commented Nov 16, 2021

menghif left a comment

Choose a reason for hiding this comment

nguyenhung15913 commented Nov 17, 2021

menghif left a comment

Choose a reason for hiding this comment

humphd commented Nov 18, 2021

Andrewnt219 left a comment

Choose a reason for hiding this comment

humphd commented Nov 20, 2021

Andrewnt219 left a comment • edited Loading

Choose a reason for hiding this comment

Andrewnt219 Nov 20, 2021 • edited Loading

Choose a reason for hiding this comment

Andrewnt219 left a comment

Choose a reason for hiding this comment

Andrewnt219 left a comment

Choose a reason for hiding this comment

Andrewnt219 Nov 21, 2021

Choose a reason for hiding this comment

Andrewnt219 Nov 21, 2021

Choose a reason for hiding this comment

Andrewnt219 left a comment

Choose a reason for hiding this comment

humphd Nov 21, 2021

Choose a reason for hiding this comment

nguyenhung15913 commented Nov 16, 2021 •

edited

Loading

Andrewnt219 left a comment •

edited

Loading

Andrewnt219 Nov 20, 2021 •

edited

Loading