-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes issue #2357: Update status url to point to either dev or prod status service url #2432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was literally thinking about the need for this earlier today, and here you go and fix it! Awesome!
I need to add this URL to the Vercel env manually, which I'll do now.
Add |
Would this file be the |
Sorry, "I added..." I have to do it manually, it's done. |
Apologizes for the late fix, vercel changes means this PR will probably have 1 failing test no matter what if I'm understanding this right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear why Vercel keeps needing authorization for this STATUS_URL
variable. I've tweeted them to ask if I'm doing it wrong (I did it the same as we usually do).
docker/production.yml
Outdated
@@ -52,6 +52,7 @@ services: | |||
- WEB_URL | |||
- SEARCH_URL | |||
- FEED_DISCOVERY_URL | |||
- STATUS_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought @manekenpix said to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confused that with another declaration above, my mistake. Gonna clear this rn
Based on https://twitter.com/leeerob/status/1455553924119740421 I've disable git fork protection, so hopefully the next PR/push will not need Vercel authorization. |
Issue This PR Addresses
This PR closes #2357
Type of Change
Description
The current status icon pointed to the production url for the status service. This is due to it being hard-coded. This PR addresses that by updating our docker config, next config, and the status icon's href to point to the correct status service url based on environment settings.
NOTE: This might not work immediately on the vercel views because they need to be updated as well. cc @humphd if this doesn't work off the bat.
Checklist