-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a planet microservice #2396
Conversation
7d2fb9a
to
1371bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good. Tested on dev and works well. Left some comments.
"version": "1.0.0", | ||
"description": "A service the planet version of Telescope", | ||
"scripts": { | ||
"dev": "env-cmd -f env.local nodemon src/server.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@@ -0,0 +1,186 @@ | |||
const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this file goes in, we can expose the invalid/delayed feeds data from here as well (#653 etc)
src/api/planet/src/index.js
Outdated
"'self'", | ||
// proxying webpack's dev server requires unsafe-eval, see: | ||
// https://github.com/vercel/next.js/issues/7457#issuecomment-497092526 | ||
"'unsafe-eval'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? I don't see webpack in planet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I was reusing what we have somewhere else. I'll remove it
1371bf7
to
b8c66e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only a couple minor things. If you fix these, feel free to merge this when you're done (I don't need to see it again).
I'm pretty sure this fixes #1257 as well. |
b8c66e7
to
30a2855
Compare
Type of Change
Description
This PR adds a new microservice for the
planet
version of Telescope.https://dev.telescope.cdot.systems/planet
Checklist