Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a planet microservice #2396

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

manekenpix
Copy link
Member

@manekenpix manekenpix commented Oct 26, 2021

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR adds a new microservice for the planet version of Telescope.

https://dev.telescope.cdot.systems/planet

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. Tested on dev and works well. Left some comments.

"version": "1.0.0",
"description": "A service the planet version of Telescope",
"scripts": {
"dev": "env-cmd -f env.local nodemon src/server.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

src/api/posts/src/index.js Show resolved Hide resolved
@@ -0,0 +1,186 @@
const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this file goes in, we can expose the invalid/delayed feeds data from here as well (#653 etc)

src/backend/web/routes/index.js Outdated Show resolved Hide resolved
"'self'",
// proxying webpack's dev server requires unsafe-eval, see:
// https://github.com/vercel/next.js/issues/7457#issuecomment-497092526
"'unsafe-eval'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I don't see webpack in planet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I was reusing what we have somewhere else. I'll remove it

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple minor things. If you fix these, feel free to merge this when you're done (I don't need to see it again).

docker/docker-compose.yml Outdated Show resolved Hide resolved
src/api/planet/src/index.js Outdated Show resolved Hide resolved
@humphd
Copy link
Contributor

humphd commented Oct 31, 2021

I'm pretty sure this fixes #1257 as well.

@manekenpix manekenpix merged commit 0d83efa into Seneca-CDOT:master Oct 31, 2021
@manekenpix manekenpix deleted the planet-docker branch October 31, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/planet won't load images due to CSP
2 participants