Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #653 - Modifying error passing to invalidation code #2388

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix #653 - Modifying error passing to invalidation code #2388

merged 1 commit into from
Oct 27, 2021

Conversation

joshuali7536
Copy link
Contributor

@joshuali7536 joshuali7536 commented Oct 23, 2021 •
edited
Loading

Issue This PR Addresses

Fixes #653

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR modifies the invalidateFeed code to receive and store the error message thrown when a parsing job fails into the database.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: Changes can be viewed in the commit 47dd9da
  • Documentation: Changes were made to backend and did not modify existing variables/configurations.

@joshuali7536
Copy link
Contributor Author

@humphd how do I fix this error with the Prettier Check? Also how would I test this change in the code?

@humphd
Copy link
Contributor

humphd commented Oct 23, 2021

Your environment isn't setup correctly. You should set it up correctly and/or run npm run prettier to do it manually.

humphd
humphd previously approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@humphd humphd marked this pull request as ready for review October 24, 2021 00:36
@humphd humphd requested a review from c3ho October 24, 2021 00:36
Grommers00
Grommers00 previously approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@humphd
Copy link
Contributor

humphd commented Oct 27, 2021

@joshuali7536 can you squash and rebase this on master for me? Then I can merge it.

@joshuali7536 joshuali7536 dismissed stale reviews from Grommers00 and humphd via 4bbda34 October 27, 2021 17:19
@joshuali7536
Copy link
Contributor Author

Ok squash and rebase complete!

@humphd humphd merged commit dfb080e into Seneca-CDOT:master Oct 27, 2021
@humphd humphd mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd left review comments

@Grommers00 Grommers00 Grommers00 left review comments

@c3ho c3ho Awaiting requested review from c3ho

@cindyorangis cindyorangis Awaiting requested review from cindyorangis

@manekenpix manekenpix Awaiting requested review from manekenpix

Assignees

@joshuali7536 joshuali7536

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper logging for invalid feeds
3 participants
@joshuali7536 @humphd @Grommers00