-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2369 Update environment setup documentation #2375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44adb14
to
797cb78
Compare
manekenpix
reviewed
Oct 21, 2021
manekenpix
reviewed
Oct 21, 2021
9e89244
to
cda3391
Compare
cda3391
to
66330e1
Compare
66330e1
to
3256d69
Compare
humphd
previously approved these changes
Oct 26, 2021
DukeManh
reviewed
Oct 27, 2021
3256d69
to
8803cdd
Compare
humphd
previously approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good, just one thing I think we should add.
Grommers00
previously approved these changes
Oct 27, 2021
@cindyledev rebase, squash, and merge when ready! Thanks for doing this, it's awesome. |
… for redis and elasticsearch
8803cdd
to
67ee8f4
Compare
Thanks for the reviews! I will merge after the checks have passed |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Closes #2369 Outdated environment setup documentation
Type of Change
Description
I added a neat table of content at the top of our environment-setup because honestly, it was becoming hard to read and navigate. I also updated the instructions for some of the steps to reflect the new changes that were added so new and returning Telescope developers can get their environment up and running correctly.
Checklist